fix: build error with c++17 #6590
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2024
tomekzaw
approved these changes
Oct 11, 2024
|
I should've published a PR first and test it later instead, you were faster than me @jeanregisser 😅 |
tjzel
approved these changes
Oct 11, 2024
Merged
via the queue into
software-mansion:main
with commit Oct 11, 2024
608a909
17 of 18 checks passed
tjzel
pushed a commit
that referenced
this pull request
Oct 11, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> There was a small typo in #6553 which caused building with c++17 to still fail. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> Build works again with RN 0.72 which uses c++17. ## Notes - Fixes #6512 (comment) - Fixes #6584
Merged
tjzel
added a commit
that referenced
this pull request
Oct 11, 2024
## Summary Picking: - #6590 ## Note I picked GitHub Actions from main to this branch from main so CIs would actually run on this pull request. Some of them are expected to fail (like cpp linting), since they got changed but these changes weren't picked into this branch. --------- Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a small typo in #6553 which caused building with c++17 to still fail.
Test plan
Build works again with RN 0.72 which uses c++17.
Notes
react-native-reanimated3.15.2 (RN 0.72.15, NDK 23) #6512 (comment)